Speed up a few browsers #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some browsers and calling #mooseInterestingEntity in their #miSelectedItem method. This will either return a moose entity if a collection has 1 element or return a moose specialized group. I think this is not a good idea because this means we will generate moose groups each time we ask for the selected entity, which can happen often. For exemple to know if we should display the propagate or the inspect button in each browsers, at each refresh. In an image with small models this can be ignored, but when you start to have big models it becomes really long to always create moose groups of thousands of elements. I propose to remove the call to this method and instead to use it only in one place: The MiInspect command. This is, I think, the only place where it is interesting to have a specialized group (and I'm not even sure). I have an image of 1.7Gb and opening the query browser went from 3sec to 300ms with this change. And this is the same for each action causing a refresh of the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some browsers and calling #mooseInterestingEntity in their #miSelectedItem method. This will either return a moose entity if a collection has 1 element or return a moose specialized group.
I think this is not a good idea because this means we will generate moose groups each time we ask for the selected entity, which can happen often. For exemple to know if we should display the propagate or the inspect button in each browsers, at each refresh.
In an image with small models this can be ignored, but when you start to have big models it becomes really long to always create moose groups of thousands of elements.
I propose to remove the call to this method and instead to use it only in one place: The MiInspect command. This is, I think, the only place where it is interesting to have a specialized group (and I'm not even sure).
I have an image of 1.7Gb and opening the query browser went from 3sec to 300ms with this change. And this is the same for each action causing a refresh of the browser.