Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the use of FASTFortranTFortranBinaryExpression ? #37

Closed
NicolasAnquetil opened this issue Sep 8, 2023 · 3 comments
Closed

What's the use of FASTFortranTFortranBinaryExpression ? #37

NicolasAnquetil opened this issue Sep 8, 2023 · 3 comments

Comments

@NicolasAnquetil
Copy link
Contributor

since operator/left//right are defined in FASTFortranBinaryExpression, why having a trait ?

@lsafina
Copy link
Contributor

lsafina commented Sep 25, 2023

If I understood correctly, we can not instantiate a trait so we still need the class FortranBinaryExpression inheriting TBinaryExpression. So we could only a) delete left/right from FortranBinaryExpression, b) delete left/right from TBinaryExpression, c) keep both.

@NicolasAnquetil what do you prefer?

@NicolasAnquetil
Copy link
Contributor Author

That is correct: cannot instantiate a Trait

I prefer (a): put left/right in TBinaryExpression and have FortranBinaryExpression "inherit" them from the trait
There is also a need for an operator in TBinaryExpression.
It can be just a String for now.

@lsafina
Copy link
Contributor

lsafina commented Sep 26, 2023

move left/right, operator from unary/binary expressions to the traits level
merged

@lsafina lsafina closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants