Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace detect:ifOne: with detect:ifFound: #14

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Gabriel-Darbord
Copy link
Member

The detect:ifOne: method is from the CollectionExtensions project (transitive dependency through Famix), and has worse performance than the detect:ifFound: method originally found in the image.
I would also like to cut this dependency from Famix in the future.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11592465606

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.413%

Totals Coverage Status
Change from base Build 11517505204: 0.0%
Covered Lines: 1789
Relevant Lines: 1875

💛 - Coveralls

@Gabriel-Darbord Gabriel-Darbord merged commit 17df86b into v5 Nov 4, 2024
1 check passed
@Gabriel-Darbord Gabriel-Darbord deleted the remove-collectionextensions-dependency branch November 4, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants