Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace material icons with symbols #1194

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jorys-paulin
Copy link
Contributor

This pull request replaces the Material Symbols used in some parts of the UI with Material icons, used for every other icon, allowing for a consistant style of icons throughout the whole Moonlight UI.

The icons in question are the following:

  • The warning icon used in the PC list when a PC is offline
  • The play and stop icons used in the app list when an app is running

Here are screenshots of the changes:

warning-before-after
play-stop-before-after

I've also tried to update all icons to Material symbols to see how it would look, but ultimately decided to stick with Material icons, as those are used by basically every other Moonlight client, so I decided to stick with Material icons for consistency with those.
For reference, here's how the toolbar icon buttons would look like with Material symbols instead:

Moonlight_2024-02-12_18-29-26

@jorys-paulin jorys-paulin marked this pull request as ready for review February 28, 2024 08:24
@cgutman
Copy link
Member

cgutman commented Jun 8, 2024

I actually think the rounded corners of the symbols look better (I remember looking at both designs when I added these). If we going to change things, I'd prefer we go the other way and change them all to the rounded corner symbols.

@cgutman cgutman added this to the v6.1 milestone Jun 19, 2024
@jorys-paulin jorys-paulin changed the title Replace material symbols with icons Replace material icons with symbols Jul 3, 2024
@jorys-paulin
Copy link
Contributor Author

I've updated the icons to Material symbols.
Personnally, I don't think they fit with the rest of the interface, since they are rounded while other things like the box art isn't.
There's also a part of "it's been like this since the start in 2018" too, I have to admit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants