Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added resolutions in list: 1440 (16/9), 540p UW, 1080p UW, 1440p UW #386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Specthram
Copy link

hi,
Just for add UW resolutions in the list :). Tested, it works.
Thanks

Copy link
Collaborator

@jorys-paulin jorys-paulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultrawide résolutions aren't officially supported, you should add "beta" or "unofficial" before ultrawide resolutions.

@Specthram
Copy link
Author

Specthram commented Jan 12, 2018

i updated titles with "(beta)". Is it ok for you ?

@jorys-paulin
Copy link
Collaborator

On a previous issue @cgutman also wanted to make the 1440p "beta" but since it's now supported by GeForce Experience it should be OK.

@jorys-paulin
Copy link
Collaborator

@Specthram Why did you added 576p UW btw?

@Specthram
Copy link
Author

Specthram commented Jan 16, 2018

because it's the 720p equivalent in UW. I think it can be great for lower connections speeds. I'm not sure if it's exactly 1280x540.
is it ok for you ? :)

@ghost
Copy link

ghost commented Feb 3, 2018

Hello all,
I also need a 1440p 2560x1440 for an iMac (and, only if possible, 2560x1600 for a Macbook Pro, it's in 16:10 format), I'm trying to understand how I can compil into a Chrome plugin myself because (sorry i'm new at GitHub) it seems the change that @Specthram add isn't already merged in the master branch.
Maybe i'm wrong ?
Nice work btw ;)

@ghost
Copy link

ghost commented Feb 11, 2018

OK, I did it, and it's working well, my fork is there : https://github.com/waumand/moonlight-chrome/tree/patch-1
And the build version for who didn't want to build himself :
moonlight-chrome.crx.zip

As you can see there are new 16:9 resolutions and also some resolutions in 16:10 that used with Macbook Pro and some others computers.
I tried many games and I can tell now : it's working very well, the quality is improved with an iMac and a MacBook Pro Retina.

Rocket League in 1440p 60fps, 100mbps in Ethernet, ultra settings, with an One Controller : it's very impressive :-)

@ghost
Copy link

ghost commented Feb 14, 2018

New fork with new resolutions. Support for 16:9 16:10 and 21:9 : https://github.com/waumand/moonlight-chrome/tree/patch-2

And the build is here :
Moonlight new resolutions.zip

@jorys-paulin
Copy link
Collaborator

@waumand Just checked out your build, pretty good stuff! I personally find there are too many resolutions, but I guess someone will need them. Bon travail!

@KayZey
Copy link

KayZey commented Feb 14, 2018 via email

@KayZey
Copy link

KayZey commented May 31, 2018

Are you still making these?

@jorys-paulin
Copy link
Collaborator

@KayZey We're waiting for the devs to merge it... In the meantime, you can use his build.

@ghost
Copy link

ghost commented Jun 1, 2018

I'm still compil it, in my fork. I've improved a bit the visibility.
But yes, waiting to merge in official build 📦
My last build, 0.9 version : https://www.dropbox.com/s/ykx1mwq6wq2g9j8/moonlight-chrome.crx.zip?dl=0
or :
moonlight-chrome.crx.zip

Have fun =)

@jorys-paulin
Copy link
Collaborator

@waumand @Specthram The PR now has merge issues, but I think we could implement custom resolutions together with something like code sharing. What do you think?

@ghost
Copy link

ghost commented Aug 6, 2018

@jorys-paulin @Specthram it's a good idea. Do it as you prefer, my goal is to help people so take what you need, modify and use what you want. I don't care about rewards ^^
And if you need me for something else don't hesitate :)

@jorys-paulin
Copy link
Collaborator

@waumand Maybe you can join the discord, that will help top better make it happen. That's your call.#477

@Specthram
Copy link
Author

hi, conflicts solved

@jorys-paulin
Copy link
Collaborator

Hey @Specthram, sorry for taking so long to respond. Lately, the team has been working hard on the QT version, but I still hope to release 1.0. Maybe it'll happen one day. I'll ask permission to merge.

@Specthram
Copy link
Author

happy birthday, pull request

@cgutman
Copy link
Member

cgutman commented Jan 20, 2019

I'm concerned with the number of resolutions too. I don't want to have a hardcoded list of every possible resolution for the user to have to look through.

With the native PC client, we can just ask the OS what it supports, but we can't do that in NaCl. Do you actually have a ChromeOS device with an ultrawide monitor?

@Specthram
Copy link
Author

Hello,
I haven't any ChromeOS device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants