Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor chains code in subdirectories #789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nanocryk
Copy link
Contributor

Move chain specific code inside a new "chains" folder:

  • Current "container-chains" folder is moved to "chains/container-chains"
  • Current "solo-chains" folder is moved to "chains/orchestrator-relays"
  • Folders "node" and "runtime" are moved inside "chains/orchestrator-paras".

Root Cargo.toml is updated while no crate name has been changed to avoid any CI breakage.

@nanocryk nanocryk added a0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Dec 19, 2024
@nanocryk nanocryk force-pushed the jeremy-refactor-repo-separate-chains branch from 00e75fb to 75bd103 Compare December 19, 2024 11:47
Copy link
Contributor

WASM runtime size check:

Compared to target branch

dancebox runtime: 1428 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2144 KB (+2144 KB) ⚠️

container chain template simple runtime: 1124 KB (-4296 KB) ✅

container chain template frontier runtime: 1400 KB (-5152 KB) ✅

Copy link
Contributor

Coverage Report

(master)

@@                           Coverage Diff                           @@
##           master   jeremy-refactor-repo-separate-chains     +/-   ##
=======================================================================
  Coverage   65.15%                                 65.15%   0.00%     
  Files         327                                    327             
  Lines       57299                                  57299             
=======================================================================
  Hits        37330                                  37330             
  Misses      19969                                  19969             
Files Changed Coverage

Coverage generated Thu Dec 19 13:16:32 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant