Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ethereum params #788

Merged
merged 2 commits into from
Dec 19, 2024
Merged

change ethereum params #788

merged 2 commits into from
Dec 19, 2024

Conversation

girazoki
Copy link
Collaborator

Updates holesky params as they were wrong.

We need to cherry-pick this into runtime-1000

@girazoki girazoki added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1428 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2144 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

Copy link
Contributor

Coverage Report

(master)

@@                    Coverage Diff                     @@
##           master   girazoki-update-holesky     +/-   ##
==========================================================
  Coverage   65.15%                    65.15%   0.00%     
  Files         327                       327             
  Lines       57299                     57299             
==========================================================
  Hits        37330                     37330             
  Misses      19969                     19969             
Files Changed Coverage

Coverage generated Thu Dec 19 10:49:43 UTC 2024

@girazoki girazoki merged commit 49bcaf6 into master Dec 19, 2024
42 checks passed
@girazoki girazoki deleted the girazoki-update-holesky branch December 19, 2024 10:50
girazoki added a commit that referenced this pull request Dec 19, 2024
dimartiro pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants