Refactor on_container_author_noted hook to take a Vec

[tmpolaczyk]

To get a more accurate weight, it's better to have a function that takes a list of n chains to reward than to call a function n times.

Should be a refactor but there are some observable changes:

• Block 0 of each container chain is no longer being rewarded. It's the genesis block and it's not created by a collator, so the collator shouldn't get any reward
• The event order changes. In pseudocode:

// Previous order:
for para_id in paras { for pallet in pallets { pallet.emit_event(para_id) }}

// New order:
for pallet in pallets { for para_id in paras { pallet.emit_event(para_id) }}

[github-actions]

WASM runtime size check:

Compared to target branch

dancebox runtime: 1420 KB (+4 KB) ⚠️

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2160 KB (+8 KB) ⚠️

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

[github-actions]

Coverage Report

(master)

@@                         Coverage Diff                          @@
##           master   tomasz-refactor-author-noted-vec      +/-   ##
====================================================================
- Coverage   65.15%                             65.14%   -0.01%     
  Files         330                                330              
+ Lines       57796                              57814      +18     
====================================================================
+ Hits        37655                              37660       +5     
+ Misses      20141                              20154      +13     

Files Changed	Coverage
/chains/orchestrator-paras/runtime/dancebox/src/weights/pallet_author_noting.rs	53.66% (-2.75%)	❗
/chains/orchestrator-paras/runtime/dancebox/src/weights/pallet_services_payment.rs	75.00% (+1.09%)	✅
/chains/orchestrator-paras/runtime/flashbox/src/weights/pallet_author_noting.rs	34.15% (-1.75%)	❗
/chains/orchestrator-paras/runtime/flashbox/src/weights/pallet_services_payment.rs	16.67% (+3.63%)	✅
/chains/orchestrator-relays/runtime/dancelight/src/weights/pallet_author_noting.rs	34.15% (-0.06%)	❗
/chains/orchestrator-relays/runtime/dancelight/src/weights/pallet_services_payment.rs	17.14% (+3.71%)	✅
/pallets/author-noting/src/lib.rs	87.22% (-0.28%)	❗
/pallets/author-noting/src/weights.rs	26.83% (-1.38%)	❗
/pallets/inflation-rewards/src/lib.rs	90.37% (-0.14%)	❗
/pallets/services-payment/src/lib.rs	89.94% (-0.03%)	❗
/pallets/services-payment/src/weights.rs	14.58% (+1.54%)	✅

Coverage generated Mon Jan 13 10:09:11 UTC 2025

[girazoki]

I think it looks good. Just double checking:

• we dont need migrations
• changing the order (iterate over paras vs iterate over pallets first) does not affect

[chexware]

Looks good to me!

[dimartiro]

Looks good to me! 👏