Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict governance messages to governance channel id #786

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Dec 17, 2024

ReceiveValidators message will now only be processed if it comes from the PRIMARY_GOVERNANCE_CHANNEL

Copy link
Contributor

github-actions bot commented Dec 17, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1428 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2132 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

@tmpolaczyk tmpolaczyk added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Dec 20, 2024
Copy link
Contributor

Coverage Report

(master)

@@                     Coverage Diff                      @@
##           master   tomasz-governance-channel     +/-   ##
============================================================
  Coverage   65.15%                      65.15%   0.00%     
  Files         327                         327             
+ Lines       57299                       57304      +5     
============================================================
+ Hits        37330                       37335      +5     
  Misses      19969                       19969             
Files Changed Coverage
/primitives/bridge/src/symbiotic_message_processor.rs 92.00% (+2.00%)

Coverage generated Fri Dec 20 13:15:19 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants