Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test operator from Ethereum bridge produces blocks #785

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

nanocryk
Copy link
Contributor

Adds a node in the moonwall config that'll produce blocks. It is not automatically added to invulnerables/whitelisted validators (that's good). We rotate its nimbus key and register it so it'll be eligible to produce blocks. After the operators are bridged, we wait a bit before checking it is the author of a block.

@nanocryk nanocryk added a0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes labels Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 17, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1428 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2144 KB (+2144 KB) ⚠️

container chain template simple runtime: 1124 KB (-4296 KB) ✅

container chain template frontier runtime: 1400 KB (-5152 KB) ✅

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Coverage Report

(master)

@@                            Coverage Diff                             @@
##           master   jeremy-eth-bridge-test-block-production     +/-   ##
==========================================================================
  Coverage   65.15%                                    65.15%   0.00%     
  Files         327                                       327             
  Lines       57299                                     57299             
==========================================================================
  Hits        37330                                     37330             
  Misses      19969                                     19969             
Files Changed Coverage

Coverage generated Wed Dec 18 10:30:48 UTC 2024

Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small coment

@girazoki girazoki merged commit e2da250 into master Dec 18, 2024
42 checks passed
@girazoki girazoki deleted the jeremy-eth-bridge-test-block-production branch December 18, 2024 15:02
dimartiro pushed a commit that referenced this pull request Dec 23, 2024
* wip test operator produces blocks (not working)

* properly fetch author

* working test

* simplify test

* Add comment for key rotation

Co-authored-by: girazoki <[email protected]>

---------

Co-authored-by: girazoki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants