Reward block author in Dancelight #784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchdancebox runtime: 1428 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2136 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
tmpolaczyk
added
B7-runtimenoteworthy
Coverage Report@@ Coverage Diff @@
## master tomasz-reward-block-author +/- ##
==============================================================
- Coverage 65.15% 65.14% -0.01%
Files 327 327
+ Lines 57299 57308 +9
==============================================================
+ Hits 37330 37333 +3
+ Misses 19969 19975 +6
|
girazoki
reviewed
Dec 17, 2024
...es/dev-tanssi-relay/external-validators-rewards/test_external_validator_reward_candidates.ts
Outdated
Show resolved
Hide resolved
girazoki
reviewed
Dec 18, 2024
| const totalRewards = validatorRewards.total.toBigInt(); | ||
|
|
||
| // Validators get 20 points for creating a block, so if they included a candidate, they will get more than 20 | ||
| expect(totalRewards).to.be.greaterThan(20n); |
There was a problem hiding this comment.
wait they get 20 per candidate and per block created. So you will always have higher than 20?
There was a problem hiding this comment.
I guess if so, you need to check the rewards totalRewards > num_blocks*20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only rewarding the Dancelight block author for including parachain candidates, but not for the block per se. So an empty block would get no reward.
This PR fixed that by rewarding 20 points to the block author, same as in polkadot.
https://github.com/paritytech/polkadot-sdk/blob/48c6574b1a32893e6a2113622d009cefda0a5f21/substrate/frame/staking/src/pallet/impls.rs#L1411