Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pallet staking tests for starlight (typescript) #782

Merged
merged 29 commits into from
Dec 19, 2024

Conversation

tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Dec 11, 2024

Add typescript tests for pallet_pooled_staking in Dancelight. They need some changes from the Dancebox tests because now we must create container chain blocks, as the relay block author is not rewarded through staking.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1428 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2144 KB (+2144 KB) ⚠️

container chain template simple runtime: 1124 KB (-4296 KB) ✅

container chain template frontier runtime: 1400 KB (-5152 KB) ✅

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Coverage Report

(master)

@@                        Coverage Diff                        @@
##           master   tomasz-starlight-staking-tests     +/-   ##
=================================================================
  Coverage   65.15%                           65.15%   0.00%     
  Files         327                              327             
  Lines       57299                            57299             
=================================================================
  Hits        37330                            37330             
  Misses      19969                            19969             
Files Changed Coverage

Coverage generated Thu Dec 19 18:39:12 UTC 2024

Base automatically changed from tomasz-starlight-staking to master December 12, 2024 15:47
@tmpolaczyk tmpolaczyk marked this pull request as ready for review December 17, 2024 15:12
@tmpolaczyk tmpolaczyk added the B0-silent Changes should not be mentioned in any release notes label Dec 17, 2024
@tmpolaczyk tmpolaczyk added D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes labels Dec 17, 2024
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job @tmpolaczyk

@tmpolaczyk tmpolaczyk merged commit b4fa19d into master Dec 19, 2024
42 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-starlight-staking-tests branch December 19, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime/client code not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants