Revisit xcm config for dancelight #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimartiro
force-pushed
the
diego-revisit-xcm_config
branch
from
1ba37c3 to
02d3208
Compare
WASM runtime size check:Compared to target branchdancebox runtime: 1428 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2144 KB (+2144 KB) container chain template simple runtime: 1124 KB (-4296 KB) ✅ container chain template frontier runtime: 1400 KB (-5152 KB) ✅ |
dimartiro
force-pushed
the
diego-revisit-xcm_config
branch
2 times, most recently
from
c08d372 to
91929be
Compare
Coverage Report@@ Coverage Diff @@
## master diego-revisit-xcm_config +/- ##
============================================================
- Coverage 65.23% 65.15% -0.08%
+ Files 325 327 +2
+ Lines 56893 57299 +406
============================================================
+ Hits 37111 37330 +219
+ Misses 19782 19969 +187
|
dimartiro
added
D3-trivial
dimartiro
force-pushed
the
diego-revisit-xcm_config
branch
2 times, most recently
from
b664b26 to
7ea312c
Compare
girazoki
reviewed
Dec 11, 2024
tmpolaczyk
reviewed
Dec 13, 2024
solo-chains/runtime/dancelight/src/tests/common/xcm/expected_event_checker.rs
Outdated
Show resolved
Hide resolved
Agusrodri
reviewed
Dec 13, 2024
Agusrodri
reviewed
Dec 13, 2024
dimartiro
force-pushed
the
diego-revisit-xcm_config
branch
from
233b6fa to
1588a3f
Compare
dimartiro
force-pushed
the
diego-revisit-xcm_config
branch
from
bda7c82 to
af981e7
Compare
Agusrodri
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following issues with the dancelight XCM configuration: