-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow rotating a subset of collators instead of all of them #770
base: master
Are you sure you want to change the base?
Conversation
WASM runtime size check:Compared to target branchdancebox runtime: 1416 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2144 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master tomasz-rotate-subset +/- ##
========================================================
+ Coverage 65.15% 65.27% +0.12%
+ Files 327 329 +2
+ Lines 57299 57620 +321
========================================================
+ Hits 37330 37608 +278
+ Misses 19969 20012 +43
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the unresolved conversations all looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general I think it looks good, just a few nitpicks from open conversations!
Adds new field to pallet_configuration: full_rotation_mode. Allows to specify how to perform the rotation, allowing a different value for each kind of chain (orchestrator, parachain, parathread):
Contains migration for configuration pallet. I had to fix the migration because it used a hardcoded key that depends on pallet name, thus failing in dancelight.