Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark for on_container_author_noted only #767

Merged
merged 12 commits into from
Dec 16, 2024

Conversation

nanocryk
Copy link
Contributor

This new bench will allow us to get a better idea of how much 1 author noting progress costs, and thus better estimate how much we can support in one block.

Do you see any issue removing the condition over runtime-benchmarks features in the runtimes? set_latest_author_data will change weight but as it is Mandatory the weight hint doesn't matter IIRC.

@nanocryk nanocryk added a0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1428 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2132 KB (+2132 KB) ⚠️

container chain template simple runtime: 1124 KB (-4296 KB) ✅

container chain template frontier runtime: 1400 KB (-5152 KB) ✅

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Coverage Report

(master)

@@                            Coverage Diff                             @@
##           master   jeremy-bench-on-container-author-noted      +/-   ##
==========================================================================
- Coverage   65.28%                                   65.23%   -0.05%     
  Files         325                                      325              
+ Lines       56845                                    56893      +48     
==========================================================================
+ Hits        37109                                    37111       +2     
+ Misses      19736                                    19782      +46     
Files Changed Coverage
/pallets/author-noting/src/weights.rs 28.21% (-8.00%)
/pallets/services-payment/src/lib.rs 89.97% (+0.03%)
/runtime/dancebox/src/weights/pallet_author_noting.rs 56.41% (-16.92%)
/runtime/flashbox/src/weights/pallet_author_noting.rs 35.90% (-10.77%)
/solo-chains/runtime/dancelight/src/weights/pallet_author_noting.rs 34.21% (-10.62%)

Coverage generated Mon Dec 16 10:22:35 UTC 2024

Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good jeremy

@tmpolaczyk
Copy link
Contributor

So this new weight is not being used, it's only for "documentation" purposes, correct?

@girazoki
Copy link
Collaborator

So this new weight is not being used, it's only for "documentation" purposes, correct?

yes for now

@nanocryk nanocryk merged commit 6a69c78 into master Dec 16, 2024
42 checks passed
@nanocryk nanocryk deleted the jeremy-bench-on-container-author-noted branch December 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants