-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark for on_container_author_noted only #767
Conversation
WASM runtime size check:Compared to target branchdancebox runtime: 1428 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2132 KB (+2132 KB) container chain template simple runtime: 1124 KB (-4296 KB) ✅ container chain template frontier runtime: 1400 KB (-5152 KB) ✅ |
Coverage Report@@ Coverage Diff @@
## master jeremy-bench-on-container-author-noted +/- ##
==========================================================================
- Coverage 65.28% 65.23% -0.05%
Files 325 325
+ Lines 56845 56893 +48
==========================================================================
+ Hits 37109 37111 +2
+ Misses 19736 19782 +46
|
…tainer-author-noted
…tainer-author-noted
…tainer-author-noted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good jeremy
So this new weight is not being used, it's only for "documentation" purposes, correct? |
yes for now |
This new bench will allow us to get a better idea of how much 1 author noting progress costs, and thus better estimate how much we can support in one block.
Do you see any issue removing the condition over
runtime-benchmarks
features in the runtimes?set_latest_author_data
will change weight but as it is Mandatory the weight hint doesn't matter IIRC.