-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starlight <> Ethereum: Rewards mapping #761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egate-message-origin
…egate-message-origin
Coverage Report@@ Coverage Diff @@
## master agustin-map-rewards +/- ##
=======================================================
+ Coverage 64.56% 64.73% +0.17%
+ Files 320 323 +3
+ Lines 55422 55578 +156
=======================================================
+ Hits 35781 35974 +193
- Misses 19641 19604 -37
|
tmpolaczyk
reviewed
Nov 29, 2024
tmpolaczyk
reviewed
Nov 29, 2024
tmpolaczyk
reviewed
Nov 29, 2024
ParthDesai
reviewed
Dec 6, 2024
ParthDesai
reviewed
Dec 6, 2024
girazoki
reviewed
Dec 9, 2024
girazoki
reviewed
Dec 9, 2024
girazoki
reviewed
Dec 9, 2024
girazoki
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, the rest looks good to me
nanocryk
approved these changes
Dec 9, 2024
ParthDesai
reviewed
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D5-nicetohaveaudit⚠️
PR contains trivial changes to logic that should be properly reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR takes care of generating a specific command called
ReportRewards
, which is used to map and encode rewards data happening in Starlight. This information will then be used by Symbiotic smart contracts on the Ethereum side to perform specific computation/checks related to rewards.More specifically, the
ReportRewards
command has the following structure:Addition of runtime api
In this PR, a
ExternalValidatorsRewardsApi
runtime api was added, containing two main functions:Where:
generate_rewards_merkle_proof
: generates a merkle proof for a givenaccount_id
andera_index
. If theaccount_id
was not rewarded in that era or was not present in the validator set for some reason, it returnsNone
.verify_rewards_merkle_proof
: verifies a merkle proof (that could be previously generated by calling generate_rewards_merkle_proof).