Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Validators Rewards pallet #736

Merged
merged 53 commits into from
Nov 14, 2024
Merged

External Validators Rewards pallet #736

merged 53 commits into from
Nov 14, 2024

Conversation

nanocryk
Copy link
Contributor

@nanocryk nanocryk commented Oct 30, 2024 •
edited
Loading

Pallet storing reward points for external validators. HistoryDepth allows to specify how many eras points should be kept in storage.

@tmpolaczyk
Add pallet_external_validators, remove ValidatorManager
5811024
@tmpolaczyk
Rename extrinsics and add tests
8fa98f0
@tmpolaczyk
Fix tests
86cb5cd
@tmpolaczyk
Merge remote-tracking branch 'origin/master' into tomasz-external-val…
1c36e24 
…idators
@tmpolaczyk
Fix benchmarks
57f2949
@tmpolaczyk
typescript-api
81381cd
@tmpolaczyk
Add traits
b7b4e51
@tmpolaczyk
Merge remote-tracking branch 'origin/master' into tomasz-external-val…
b3d8c5b 
…idators
@tmpolaczyk
Merge remote-tracking branch 'origin/master' into tomasz-external-val…
abec023 
…idators
@tmpolaczyk
Some PR comments
06ac945
@tmpolaczyk
Change era every n sessions
6edc6f4
@tmpolaczyk
WIP integration test and hooks
71ae9d1
@tmpolaczyk
Merge remote-tracking branch 'origin/master' into tomasz-external-val…
5f5c819 
…idators
@tmpolaczyk
Benchmark new extrinsics
61c3fc9
@tmpolaczyk
Migrate queued keys instead of current validators
08965a8
@tmpolaczyk
typescript-api
bc61273
@tmpolaczyk
Add era index to hook
e2fe742
@tmpolaczyk
impl for tuples
99791ec
@tmpolaczyk
Make tests pass
7cde793
@tmpolaczyk
Add integration tests
09cfcec
@tmpolaczyk
current era and active era
c6cf701
@tmpolaczyk
typescript-api
a49f749
@tmpolaczyk
Add one typescript test
1187bc4
@tmpolaczyk
console log
9614ac8
@tmpolaczyk
Merge remote-tracking branch 'origin/master' into tomasz-external-val…
adc79c2 
…idators
@tmpolaczyk
run_to_block not working
6591098
@tmpolaczyk
Unit tests still not working
3375e5d
@tmpolaczyk
Fix unit tests
40fdf84
@tmpolaczyk
Start era 0 in session 0
aaadb2c
@tmpolaczyk
Merge remote-tracking branch 'origin/master' into tomasz-external-val…
8cd3a41 
…idators
@nanocryk nanocryk added a0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Nov 7, 2024
@nanocryk nanocryk marked this pull request as ready for review November 7, 2024 13:13
@girazoki
Copy link
Collaborator

girazoki commented Nov 7, 2024

Pr looks good besides:

  • let's add some integration tests in rust please
  • let's add some test in typescript (at least, making sure Alice gets reward points for creating blocks)

girazoki
girazoki approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks correct to me, waiting for anyone else to comment!

@nanocryk nanocryk merged commit a9fd0af into master Nov 14, 2024
42 checks passed
@nanocryk nanocryk deleted the jeremy-external-validators-rewards branch November 14, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agusrodri Agusrodri Agusrodri left review comments

@girazoki girazoki girazoki approved these changes

@tmpolaczyk tmpolaczyk tmpolaczyk approved these changes

Assignees
No one assigned
Labels
a0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nanocryk @girazoki @tmpolaczyk @Agusrodri