Combine RemoveParaIdsWithNoCredit and CollatorAssignmentHook

[ParthDesai]

Description

Combine RemoveParaIdsWithNoCredit and CollatorAssignmentHook in one trait with two methods.

Both method executes same logic. Only difference being pre_assignment_* method always rollback while post_assignment_* only rollback in case it errors out.

Note

Naming and tests are still remaining. Just want to get some early feedback on overall design.

[github-actions]

Coverage Report

(master)

@@                                   Coverage Diff                                   @@
##           master   combine-remove-paraids-and-collator-assignment-hook      +/-   ##
=======================================================================================
+ Coverage   64.73%                                                64.76%   +0.03%     
  Files         323                                                   323              
+ Lines       55578                                                 55740     +162     
=======================================================================================
+ Hits        35974                                                 36097     +123     
+ Misses      19604                                                 19643      +39     

Files Changed	Coverage
/pallets/collator-assignment/src/lib.rs	97.65% (+1.27%)	✅
/pallets/services-payment/src/lib.rs	89.94% (-0.33%)	❗
/primitives/traits/src/lib.rs	61.60% (-1.51%)	❗
/runtime/dancebox/src/lib.rs	87.98% (+0.21%)	✅
/runtime/dancebox/src/weights/pallet_services_payment.rs	73.91% (-13.05%)	❗
/runtime/flashbox/src/lib.rs	46.80% (+2.79%)	✅
/runtime/flashbox/src/weights/pallet_services_payment.rs	13.04% (-13.05%)	❗
/solo-chains/runtime/dancelight/src/lib.rs	67.81% (+0.90%)	✅
/solo-chains/runtime/dancelight/src/weights/pallet_services_payment.rs	13.43% (-13.44%)	❗

Coverage generated Tue Dec 10 15:09:23 UTC 2024

[github-actions]

WASM runtime size check:

Compared to target branch

dancebox runtime: 1428 KB (no changes) ✅

flashbox runtime: 824 KB (no changes) ✅

dancelight runtime: 2108 KB (+2108 KB) ⚠️

container chain template simple runtime: 1124 KB (-4296 KB) ✅

container chain template frontier runtime: 1400 KB (-5152 KB) ✅

[girazoki]

I like better the way it looks now. I am still missing some doc on what each of the lines does. If we can fix that would be great