Change solochain flag into subcommand

[tmpolaczyk]

Instead of using tanssi-node --solochain to start a starlight collator, we will use tanssi-node solochain.

This allows us to simplify the argument parsing logic, and remove all the orchestrator args from start_solochain_node.

A major change is the new keystore path. Instead of putting keystore in

Collator1000-01/data/chains/simple_container_2000/keystore

We put it in

Collator1000-01/data/config/keystore

But zombienet will put the keys in the old path, so we need to manually copy it if we are running under zombienet. See copy_zombienet_keystore function.

To generate collator keys in the new location, collators will need to add a --keystore-path argument to the tanssi-node key command.

[github-actions]

Coverage Report

(master)

@@                       Coverage Diff                       @@
##           master   tomasz-solochain-subcommand      +/-   ##
===============================================================
- Coverage   70.29%                        69.79%   -0.50%     
+ Files         266                           267       +1     
+ Lines       49052                         49395     +343     
===============================================================
- Hits        34477                         34473       -4     
+ Misses      14575                         14922     +347     

Files Changed	Coverage
/client/consensus/src/collators/lookahead.rs	77.98% (-2.13%)	🔽
/client/consensus/src/mocks.rs	64.92% (+0.06%)	🔼
/client/service-container-chain/src/service.rs	7.18% (-0.15%)	🔽
/container-chains/nodes/simple/src/command.rs	24.95% (+0.84%)	🔼
/node/src/cli.rs	60.71% (-1.11%)	🔽
/node/src/command.rs	33.93% (-4.49%)	🔽
/node/src/service.rs	15.31% (+0.50%)	🔼

Coverage generated Tue Sep 24 15:42:43 UTC 2024

[girazoki]

Please remove the comment about the TODO, as this is the behavior we observe in reegular tanssi