Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): improve dev test duration by not compiling wasm on startup #469

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Mar 21, 2024

This change make the pipeline a bit faster by removing the wasm compilation from every node startup. It generates a raw chain spec at the beginning and reuses it during the test run.

The coverage workflow on master takes around ~57 minutes, and with this change it goes to ~37 minutes.

@RomarQ RomarQ marked this pull request as ready for review March 21, 2024 21:05
@girazoki girazoki added D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes B0-silent Changes should not be mentioned in any release notes labels Mar 22, 2024
@girazoki
Copy link
Collaborator

thank you @RomarQ !

@girazoki girazoki self-requested a review March 22, 2024 07:46
Copy link
Contributor

@tmpolaczyk tmpolaczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@girazoki girazoki merged commit 02a2296 into moondance-labs:master Mar 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants