Apply current clippy lints #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
a0-pleasereview
|
Can we park this until after the polkadot 1.6.0 upgrade? Because this may cause conflicts, and that PR also updates the rust version which will add new lints that will also need to be fixed. |
nanocryk
force-pushed
the
jeremy-clippy
branch
from
d6f1c4e to
89c1433
Compare
nanocryk
added
the
D5-nicetohaveaudit⚠️
Coverage Report@@ Coverage Diff @@
## master jeremy-clippy +/- ##
=================================================
+ Coverage 67.57% 67.79% +0.22%
Files 64 64
- Lines 9241 9211 -30
=================================================
Hits 6244 6244
- Misses 2997 2967 -30
|
tmpolaczyk
approved these changes
Feb 29, 2024
girazoki
pushed a commit
that referenced
this pull request
Mar 14, 2024
* clippy auto fix * fix lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix what clippy currently complains about.
In a future PR we could add more agressive clippy lints if we want, or agree on some coding patterns not enforced by clippy.