impl_tanssi_pallets_config! macro for container chains
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
B7-runtimenoteworthy
Coverage Report@@ Coverage Diff @@
## master jeremy-construct-tanssi-runtime-macro +/- ##
========================================================================
Coverage 77.37% 77.37% 0.00%
+ Files 109 110 +1
+ Lines 28595 28620 +25
========================================================================
+ Hits 22123 22144 +21
+ Misses 6472 6476 +4
|
tmpolaczyk
reviewed
Feb 15, 2024
| @@ -917,6 +889,15 @@ impl pallet_tx_pause::Config for Runtime { | |||
| type WeightInfo = pallet_tx_pause::weights::SubstrateWeight<Runtime>; | |||
| } | |||
|
|
|||
| impl tp_impl_tanssi_pallets_config::Config for Runtime { | |||
| const SLOT_DURATION: u64 = SLOT_DURATION; | |||
There was a problem hiding this comment.
@girazoki is this configurable? Won't container chains break if you set this to something other than 12?
There was a problem hiding this comment.
I think if they missconfigure it, they wont produce blocks. So yeah maybe its better if we set it ourselves. @nanocryk can you do that?
There was a problem hiding this comment.
Maybe let's keep this until we change it to 6 seconds, the transition will be easier if this is configurable
|
@nanocryk can you merge master back? I think we can merge this after. |
tmpolaczyk
approved these changes
Feb 19, 2024
…nssi-runtime-macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a new
impl_tanssi_pallets_config!macro that implementsConfigfrompallet_author_inherent,pallet_timestampandpallet_cc_authorities_notingwith the proper parameters to work with Tanssi.Customizable parameters are set by impl
impl_tanssi_pallets_config::Config.The macro can't check at compile time that the pallets have been listed in the
construct_runtime!macro, however it will generate a test for that.