Refactor collate_on_tanssi closure, make it not async

[tmpolaczyk]

Follow-up to #408, but we can't remove this one.

[github-actions]

Coverage Report

(master)

@@                        Coverage Diff                        @@
##           master   tomasz-collate-on-tanssi-sync      +/-   ##
=================================================================
- Coverage   77.38%                          71.00%   -6.38%     
- Files         110                              73      -37     
- Lines       28620                           10444   -18176     
=================================================================
- Hits        22147                            7415   -14732     
- Misses       6473                            3029    -3444     

Files Changed	Coverage
/client/consensus/src/collators.rs	81.91% (-0.04%)	🔽
/client/consensus/src/lib.rs	28.91% (-0.55%)	🔽
/client/consensus/src/manual_seal.rs	43.24% (-51.35%)	🔽
/client/manual-xcm/src/lib.rs	23.46% (-0.93%)	🔽
/client/node-common/src/service.rs	46.93% (-1.79%)	🔽
/container-chains/templates/simple/node/src/chain_spec.rs	71.33% (+2.66%)	🔼
/container-chains/templates/simple/node/src/service.rs	85.62% (+1.96%)	🔼
/container-chains/templates/simple/runtime/src/lib.rs	82.59% (+17.95%)	🔼
/pallets/author-noting/rpc/runtime-api/src/lib.rs	0.00% (-8.33%)	🔽
/pallets/author-noting/src/lib.rs	81.91% (-0.50%)	🔽
/pallets/author-noting/src/weights.rs	36.21% (-22.41%)	🔽
/pallets/authority-assignment/src/lib.rs	91.49% (-0.35%)	🔽
/pallets/authority-mapping/src/lib.rs	76.47% (-6.86%)	🔽
/pallets/collator-assignment/rpc/runtime-api/src/lib.rs	0.00% (-5.56%)	🔽
/pallets/collator-assignment/src/lib.rs	88.26% (-7.00%)	🔽
/pallets/collator-assignment/src/weights.rs	50.00% (-50.00%)	🔽
/pallets/configuration/src/lib.rs	69.32% (-15.93%)	🔽
/pallets/configuration/src/weights.rs	50.00% (-50.00%)	🔽
/pallets/data-preservers/src/lib.rs	18.75% (-66.96%)	🔽
/pallets/inflation-rewards/src/lib.rs	85.38% (-7.80%)	🔽
/pallets/initializer/src/lib.rs	47.92% (-43.92%)	🔽
/pallets/invulnerables/src/lib.rs	72.52% (-11.57%)	🔽
/pallets/invulnerables/src/weights.rs	21.43% (-17.86%)	🔽
/pallets/pooled-staking/src/calls.rs	93.78% (-0.50%)	🔽
/pallets/pooled-staking/src/candidate.rs	96.46% (+0.85%)	🔼
/pallets/pooled-staking/src/lib.rs	42.07% (-5.88%)	🔽
/pallets/pooled-staking/src/pools.rs	98.43% (-0.94%)	🔽
/pallets/pooled-staking/src/weights.rs	5.17% (-5.17%)	🔽
/pallets/registrar/rpc/runtime-api/src/lib.rs	0.00% (-51.61%)	🔽
/pallets/registrar/src/lib.rs	82.11% (-8.06%)	🔽
/pallets/services-payment/src/lib.rs	66.54% (-22.04%)	🔽
/pallets/services-payment/src/weights.rs	16.67% (-16.66%)	🔽
/pallets/stream-payment/src/lib.rs	90.75% (+1.09%)	🔼
/primitives/author-noting-inherent/src/lib.rs	100.00% (+25.00%)	🔼
/primitives/consensus/src/lib.rs	76.47% (-20.71%)	🔽
/primitives/container-chain-genesis-data/src/lib.rs	73.58% (-0.49%)	🔽
/primitives/impl-tanssi-pallets-config/src/lib.rs	80.00% (-2.61%)	🔽
/primitives/maths/src/lib.rs	87.80% (-0.30%)	🔽
/primitives/traits/src/lib.rs	80.00% (-15.24%)	🔽
/runtime/common/src/migrations.rs	6.78% (-84.63%)	🔽

Coverage generated Thu Feb 22 18:34:14 UTC 2024

[girazoki]

LGTM