Always use wasm executor in container collators #412
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a
NativeElseWasmExecutor
for all chains, but collators don't have the container chain's native runtime. So their executor was trying to use the native dancebox runtime as the container chain runtime, which fortunately resulted in a version mismatch and the wasm container chain runtime was always used.This can be verified by starting zombienet with
export RUST_LOG=info,executor=trace
:As a bonus we now have two types of clients,
Arc<ContainerChainClient>
andArc<ParachainClient>
, and using one client in place of the other results in a compile error.