Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start_relay_chain_tasks for full nodes as well #410

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

tmpolaczyk
Copy link
Contributor

Revert part of #409. Even though both approaches seem to work, in polkadot-sdk they have it outside the if validator.

Copy link
Contributor

Coverage Report

(master)

@@                           Coverage Diff                            @@
##           master   tomasz-always-start-relay-chain-tasks     +/-   ##
========================================================================
  Coverage   76.67%                                  76.67%   0.00%     
  Files         107                                     107             
  Lines       26746                                   26746             
========================================================================
+ Hits        20506                                   20507      +1     
- Misses       6240                                    6239      -1     
Files Changed Coverage
/pallets/registrar/src/lib.rs 90.36% (+0.19%) 🔼

Coverage generated Tue Feb 13 17:50:40 UTC 2024

@girazoki girazoki added not-breaking Does not need to be mentioned in breaking changes B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes labels Feb 14, 2024
@girazoki girazoki merged commit c5d86dd into master Feb 14, 2024
30 of 32 checks passed
@girazoki girazoki deleted the tomasz-always-start-relay-chain-tasks branch February 14, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants