Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check keys registered in add_invulnerable too #405

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Feb 8, 2024

Pass the check to add_invulnerable too, a check that only existed in set_invulnerables

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Coverage Report

(master)

@@                       Coverage Diff                        @@
##           master   girazoki-invulnerables-fixes      +/-   ##
================================================================
+ Coverage   75.93%                         76.31%   +0.38%     
  Files         107                            107              
- Lines       26739                          26694      -45     
================================================================
+ Hits        20303                          20370      +67     
- Misses       6436                           6324     -112     
Files Changed Coverage
/node/src/chain_spec/dancebox.rs 95.24% (-0.02%) 🔽
/node/src/chain_spec/flashbox.rs 70.30% (-0.11%) 🔽
/pallets/configuration/src/lib.rs 85.66% (+0.41%) 🔼
/pallets/invulnerables/src/lib.rs 84.09% (+0.09%) 🔼
/runtime/dancebox/src/lib.rs 81.91% (+1.68%) 🔼
/runtime/flashbox/src/lib.rs 45.29% (+9.04%) 🔼
/runtime/flashbox/tests/common/mod.rs 99.71% (+1.77%) 🔼

Coverage generated Fri Feb 9 08:54:00 UTC 2024

@girazoki girazoki added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes not-breaking Does not need to be mentioned in breaking changes labels Feb 9, 2024
@girazoki girazoki requested a review from fgamundi February 9, 2024 08:15
@girazoki girazoki merged commit dbef222 into master Feb 9, 2024
30 checks passed
@girazoki girazoki deleted the girazoki-invulnerables-fixes branch February 9, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants