-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MD 306 - add pallet treasury #400
Merged
girazoki
merged 21 commits into
moondance-labs:master
from
augustocollado:augustocollado/MD-306-Add-Pallet-Treasury
Feb 7, 2024
Merged
MD 306 - add pallet treasury #400
girazoki
merged 21 commits into
moondance-labs:master
from
augustocollado:augustocollado/MD-306-Add-Pallet-Treasury
Feb 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
reviewed
Feb 5, 2024
girazoki
added
breaking
Needs to be mentioned in breaking changes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
labels
Feb 5, 2024
girazoki
reviewed
Feb 5, 2024
girazoki
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @augustocollado !
girazoki
approved these changes
Feb 5, 2024
girazoki
reviewed
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds pallet-treasury in dancebox & flashbox runtimes
Includes a test suite covering pallet-treasury within common-tanssi
Adds a policy to deal with fees and tips to burn 80% and collect the remainder into the treasury's account
Other considerations:
No other pallets are added (such as pallet-collective), therefore sudo is the approval/reject authority
Bond is set to 5% of the proposal, with no maximum