Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rounding in inflation test #324

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix rounding in inflation test #324

merged 1 commit into from
Nov 14, 2023

Conversation

tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Nov 14, 2023 •
edited
Loading

The issue was doing x * 2 / 10 instead of Perbill::from_percent(20) * x.

@tmpolaczyk tmpolaczyk added B0-silent Changes should not be mentioned in any release notes not-breaking Does not need to be mentioned in breaking changes labels Nov 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

Master coverage: 71.33%
Coverage generated "Tue Nov 14 10:05:41 UTC 2023":
https://d3gkbsry1ehhqi.cloudfront.net/tanssi-coverage/pulls/324/index.html
Pull coverage: 71.34%

@girazoki girazoki merged commit e3cf7de into master Nov 14, 2023
26 of 27 checks passed
@girazoki girazoki deleted the tomasz-rewards-rounding branch November 14, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmpolaczyk @girazoki