Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format files and add try-runtime feature for maintenance pallet #302

Closed
wants to merge 2 commits into from

Conversation

Chralt98
Copy link

I always find it better readable to split the std, benchmark and try-runtime features into multiple lines.

So I run taplo fmt on all Cargo.toml files. (In specific terms I used the Even Better TOML extension of VSCode.)

I also did run cargo +nightly clippy --all-features --all-targets -p container-chain-template-simple-runtime and found out that the maintenance pallet also has to enable the try-runtime feature.

Additionally I run cargo +nightly fmt to properly format mainly the imports.

@Chralt98 Chralt98 changed the title Format toml files and add try-runtime feature for maintenance pallet Format files and add try-runtime feature for maintenance pallet Oct 28, 2023
@tmpolaczyk
Copy link
Contributor

Hi, sorry for no reply. We have improved our CI with new toml linters, zepter to ensure that the features are correctly propagated, and toml maid as an alternative to taplo:

#368
#369

This is because manually keeping track of the features was very error prone, as you have noticed, so we have automated it. You shouldn't run into similar issues in the future, but if you do, feel free to open a pull request!

@tmpolaczyk tmpolaczyk closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants