Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test keep-db flag #301

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Test keep-db flag #301

merged 8 commits into from
Oct 31, 2023

Conversation

tmpolaczyk
Copy link
Contributor

@tmpolaczyk tmpolaczyk commented Oct 27, 2023

Run with:

pnpm moonwall test zombie_tanssi_keep_db

(does not run in CI).

Also includes a flowchart to help us understand the logic of database removal and keep db.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Master coverage: 71.00%
Coverage generated "Mon Oct 30 15:33:39 UTC 2023":
https://d3gkbsry1ehhqi.cloudfront.net/tanssi-coverage/pulls/301/index.html
Pull coverage: 70.63%

@girazoki
Copy link
Collaborator

dont forget to merge Master in @tmpolaczyk

@tmpolaczyk tmpolaczyk marked this pull request as ready for review October 30, 2023 09:02
Base automatically changed from agustin-keepdb-cli-flag to master October 30, 2023 13:38
Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tmpolaczyk tmpolaczyk merged commit 9c9df19 into master Oct 31, 2023
23 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-test-keepdb branch October 31, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants