make distribute_rewards transactional #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master coverage: 70.97% |
tmpolaczyk
approved these changes
Oct 27, 2023
girazoki
added a commit
that referenced
this pull request
Oct 31, 2023
* reward trait * reward distribution code * tests (wip) * reward distribution tests * fix test + remove warning * chore: create pallet inflation-rewards and primitive tp-maths * chore: move trait DistributeRewards in tp-traits * ref: move AuthorNotingHook in tp-traits * ref: pooled-staking: use Credit for rewards * reword pallet inflation rewards * ref: use bounded vec for container chains * fix existing rust tests compilation * reward orchestrator chain * add rust tests for pallet inflation-rewards * fmt * remove dead code Co-authored-by: tmpolaczyk <[email protected]> * note container author only if block increase * fmt * cleanup merge * reward author if it increases * Re-design on-container-author-noted to simplify it for now * adapt to 1.1.0 * fmt * fix merge mistakes and benchmarking * types and unitest error * take invulnerables into account * fmt * let's use collatorAssignment to fethc the author account * hack around how to get the collator account to be rewarded * fix rust tests * TODO: important! * events for inflation rewards and benchmark for rewards * add runtime event to mock * substitute extractFee for extractFeeAuthor * fix ts-tests and local interfaceS * fix linting and fmt * first ts-tests dedicated to inflation * add new parafchain bond account * add more test * fmt lint * wire in container rewarding * fmt * add more test, including container-chain reward * try-runtime * staking rewards tests, not through invlunerables * test fixed * a couple of tests for staking * make distribute_rewards transactional (#299) * make distribute_rewards transactional * fmt --------- Co-authored-by: girazoki <[email protected]> * reward the author of the first container block * PR feedback * compile * Inflation rewards integration tests (#295) * test reward distribution * ensure it still works even with key change * find_map + fmt * fmt * remove dbg! * a few todos added and cleaning the remaining feedback --------- Co-authored-by: nanocryk <[email protected]> Co-authored-by: tmpolaczyk <[email protected]> Co-authored-by: girazoki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make reward distribution reverts if anything goes wrong.