Fix try-runtime build and add missing migrations #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
reviewed
Oct 19, 2023
| } | ||
|
|
||
| fn migrate(&self, _available_weight: Weight) -> Weight { | ||
| cumulus_pallet_xcmp_queue::migration::Migration::<T>::on_runtime_upgrade() |
There was a problem hiding this comment.
do we know for certain this puts the v3 on the pallet?
There was a problem hiding this comment.
because we probably need to set v2 first before doing this on_runtime_upgrade
There was a problem hiding this comment.
Yes, even if onchain is v1, it applies first the migration to v2 and immediately after the migration to v3 https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/pallets/xcmp-queue/src/migration.rs#L36C1-L46C4
|
Can you merge master? I just merged a big PR that includes migrations, so there will be conflicts. |
girazoki
approved these changes
Oct 19, 2023
|
@tmpolaczyk done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try-runtimenow fails if there's a mismatch between a pallet's latest vs onchain versions. This flaggedPolkadotXcmandXcmpQueuefrom live dancebox.Missing migrations has been added