Allow swapping AutoCompounding shares for ManualReward shares (and the other way around) #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master coverage: 71.90% |
girazoki
reviewed
Sep 25, 2023
|
So a couple of things missing on this PR yet, so that we dont forget:
|
girazoki
reviewed
Sep 25, 2023
| ) -> DispatchResultWithPostInfo { | ||
| // Converts amount to shares of the correct pool | ||
| let old_shares = match (amount, source_pool) { | ||
| (SharesOrStake::Shares(s), _) => s, |
There was a problem hiding this comment.
is this supposed to cover shares from joining or leaving pools? what would happen in this case?
There was a problem hiding this comment.
Ah never mind, target pool only contains automcpounding and manual rewards. So its only to cover cases in which the amount is given as shares
girazoki
reviewed
Sep 25, 2023
girazoki
approved these changes
Sep 28, 2023
girazoki
reviewed
Sep 28, 2023
girazoki
reviewed
Sep 28, 2023
Co-authored-by: girazoki <[email protected]>
girazoki
approved these changes
Sep 28, 2023
tmpolaczyk
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a delegator needs to undelegate and delegate again to change in which pool their stake is, which takes time as they need to wait for the joining and leaving delays. However there is no security risk in changing pool, so it should be instant instead. This PR adds a new call to go from one pool to another, with the dust from joining the target pool considered leaving stake.
TODO: Benchmark