Pooled Staking Runtime API #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master coverage: 71.72% |
|
You need to update api-augment: |
|
I would suggest we use the same procedure as in the CI. Compile the node and do: |
|
LGTM. Can we add an integration test for this? Both rust and typescript if possible |
tmpolaczyk
reviewed
Sep 25, 2023
| candidate: Candidate<T>, | ||
| delegator: Delegator<T>, | ||
| pool: AllTargetPool, | ||
| ) -> Option<T::Balance> { |
There was a problem hiding this comment.
What does None mean here? If the stake is 0 this should return Some(0), no?
|
Also can you add some integration tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stake in currency amount is not available in storage, and instead must be computed from the amount of shares and the value of each share. The pending manual rewards also needs to be computed based on the difference between the pool counter and delegator "checkpoint" times the amount of shares.
To simplify the implementation of UIs, a new Runtime API is added to perform those computations.