Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moonbeam to polkadot stable2407 #2932

Merged
merged 60 commits into from
Oct 2, 2024
Merged

Conversation

gonzamontiel
Copy link
Contributor

@gonzamontiel gonzamontiel commented Sep 4, 2024

What does it do?

Updates Moonbeam to Polkadot SDK stable2407.
Starting from this version, the naming of versioning and the release process change as described here: RELEASE.md.

What important points reviewers should know?

Changes that affected us:

Full list of changes here.

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

See dependency pins:

gonzamontiel and others added 20 commits August 26, 2024 14:45
* add simple wasm size check

* only run on pull requests

* add Github token to env

* fix download dir name

* try comparing previous and current runtimes

* change master branch with dynamic target branch ref

* add comparison to latest release

* test with older release

* download from release instead of workflow artifact

* debug release tag not saved to env

* debug some more

* use gh cli to get releases instead of git tag

* use gh api instead of releases

* remove get build id & fix awk parsing

* build runtimes with _, releases with -

* add comment to PR and format msg

* use markdown report & replace comment

* cat report & fix comment formatting

* add twiggy diff reports as artifacts

* use upload v4 & create reports dir

* rm: deprecated ::set-output cmd
* add: storage read cost constant

* update test-pov

* update xcm-v3 tests

* update xcm-v4 tests

* add storage read gas cost to constants

* update test-precompile

* load constant in beforeAll

* replace gas cost with weight to gas ratio
…use (#2913)

* chore: rename crate manual-xcm-rpc -> moonbeam-dev-rpc

* add RPC method test_skipRelayBlocks

* allow Root to resume XCM execution

* update moonkit pin

* add dev-test that trigger auto-pause of xcm

* prettier

* dev test auto-pause xcm: remove unused imports & improve test scenario

* add pallet-emergency-para-xcm to moonriver

* add pallet-emergency-para-xcm to moonbeam

* apply review suggestions
* set the block size to 60mln gas for moonbeam

* update mbip-5 value in test
* add pallet parameters

* XcmFeesAccount

* add copyrights

* add FeesTreasuryProportion
---------

Co-authored-by: Rodrigo Quelhas <[email protected]>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2204 KB (no changes) ✅

Moonbeam runtime: 2164 KB (no changes) ✅

Moonriver runtime: 2156 KB (no changes) ✅

Compared to latest release (runtime-3200)

Moonbase runtime: 2204 KB (+244 KB compared to latest release) ⚠️

Moonbeam runtime: 2164 KB (+240 KB compared to latest release) ⚠️

Moonriver runtime: 2156 KB (+232 KB compared to latest release) ⚠️

@gonzamontiel gonzamontiel self-assigned this Sep 5, 2024
@gonzamontiel gonzamontiel added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels Sep 5, 2024
* Add XcmRecorder to XcmConfig
* Add VersionWrapper to hrmp::COnfig
* Remove code from deprecated pallet treasury
* Remove code from deprecated DmpQueue
* Remove code from deprecated XCMV2
@RomarQ
Copy link
Contributor

RomarQ commented Sep 26, 2024

This currently breaks lazy-loading, I will have a look at it

afaik, the lazy loading test was green (at least it was green, but I merged master recently).

It only fails in the first block collation attempts with:

❗️ Inherent extrinsic returned unexpected error: Error at calling runtime api: Execution failed: Execution aborted due to panic: panicked at /home/builder/cargo/git/checkouts/moonkit-d7d2e5bc44c7ff78/509c4f4/pallets/async-backing/src/consensus_hook.rs:79:17:
slot moved backwards

The issue was related to the changes in Inherent mocks.

@noandrea noandrea added the A8-mergeoncegreen Pull request is reviewed well. label Sep 30, 2024
librelois
librelois previously approved these changes Oct 1, 2024
@librelois librelois merged commit 023adc0 into master Oct 2, 2024
39 checks passed
@librelois librelois deleted the moonbeam-polkadot-stable2407 branch October 2, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants