Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.7 dependency updates #259

Merged
merged 103 commits into from
Mar 26, 2021
Merged

v0.7 dependency updates #259

merged 103 commits into from
Mar 26, 2021

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Feb 22, 2021 •
edited
Loading

AUTHORSHIP NOTICE:
This PR was opened by @notlesh and he has done most of the work on it. However, I, @JoshOrndorff, am writing this PR description.

This PR updates Moonbeam's Substrate-ecosystem dependencies as follows:
Substrate: rococo-v1#1404f2af4cbe90d35b4c8a1405a9452feb789adc
Polkadot: rococo-v1#0c9d4c9289e017b7589cc5f761d38545b833e1df
Cumulus: rococo-v1#10887b728c563329845192915069a094b3f06139
Frontier: notlesh-moonbeam-v0.7#4f958255b40cf05b155bf0256ee2f033a6b3a383

  • Make it compile
  • Make Rust unit tests pass
  • Make TS integration tests pass
  • Change frontier branch to v0.7-moonbeam (Ideally with a history cleanup, maybe in a followup)
  • Bump runtime version
  • Bump crate version? (Or does that not happen until we release?) Maybe bump it to 0.7.0-alpha

As of 24 March, this PR is up to date with moonbeam master as well as frontier master. I'd like to get this in quickly, so from here on, no more target branch changes. To the extent possible, avoid merging other PRs into master before this to avoid more conflicts.

notlesh added 19 commits February 19, 2021 07:57
@notlesh
Use official ethereum crate at version 0.7
0254852
@notlesh
Point frontier at v0.7-moonbeam
7d4eb1a
@notlesh
Bump Ethereum, cumulus/polkadot/substrate
4bd2848 
Ethereum: v0.7
cumulus: 28d1d00747e1e60a3e26f0112b4580c805fa1557
polkadot: ce03f371598eed31465391b30f8fbc22470982dd
substrate: ca63242fc848b9bff739c246e07310dd15ec25eb
@notlesh
s/cumulus-primitives/cumulus-primitives-core/
d69196d
@notlesh
Remove cumulus-runtime; bump substrate-wasm-builder version
7a56a2a
@notlesh
Rename cumulus packages and update Cargo.lock
a206829
@notlesh
Reflect rename of cumulus_primitives -> cumulus_primitives
32b9e90
@notlesh
s/cumulus_service/cumulus_client_service/
15ac76e
@notlesh
Update rust-toolchain from 2020-10-03 -> 2021-01-13
7979e13
@notlesh
More renaming to reflect upstream refactors
38c77c0
@notlesh
Bump frontier c364ac4 -> 0db6896
08ba4a9
@notlesh
Bump frontier from 0bd068ab -> cf4be1a
fccca4d
@notlesh
Update Cargo.lock
2b8909c
@notlesh
Reflect upstream naming changes
a86f372
@notlesh
Update Cargo.lock
784d448
@notlesh
Reflect more upstream name changes
364a5cd
@notlesh
More fixes
3a663ec
@notlesh
Reflect StartCollatorParams refactor
cee5e78
@notlesh
Reflect ParachainInherentData refactor
013c431
JoshOrndorff
JoshOrndorff reviewed Feb 23, 2021
View reviewed changes
Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far. CI indicates that you're still leaking std into the build somewhere.

node/src/dev_service.rs Outdated Show resolved Hide resolved
@girazoki
Copy link
Collaborator

The CI probably complaints because the change allowing us to not import funty with std is not merged yet. We opened a PR to Wei:rust-ethereum/ethereum#9

@notlesh
Copy link
Contributor Author

notlesh commented Feb 23, 2021

The CI probably complaints because the change allowing us to not import funty with std is not merged yet. We opened a PR to Wei:rust-blockchain/ethereum#9

Yes, I believe we will need bumps in both evm and ethereum for this to work. I'll revive my own branch for now so that we can get CI green for now.

@notlesh
Copy link
Contributor Author

notlesh commented Feb 24, 2021

The failing unit test is related to this PR: paritytech/substrate#8090

JoshOrndorff
JoshOrndorff reviewed Mar 26, 2021
View reviewed changes
node/Cargo.toml Outdated Show resolved Hide resolved
JoshOrndorff
JoshOrndorff suggested changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. A couple minor things to clean. And the one about the transaction payment is needed for security.

runtime/Cargo.toml Outdated Show resolved Hide resolved
runtime/Cargo.toml Outdated Show resolved Hide resolved
runtime/account/Cargo.toml Outdated Show resolved Hide resolved
runtime/precompiles/Cargo.toml Outdated Show resolved Hide resolved
runtime/src/lib.rs Show resolved Hide resolved
scripts/run-alphanet-parachain.sh Outdated Show resolved Hide resolved
tests/tests/test-filter-api.ts Outdated Show resolved Hide resolved
tests/tests/test-subscription.ts Outdated Show resolved Hide resolved
tests/tests/test-subscription.ts Outdated Show resolved Hide resolved
@JoshOrndorff JoshOrndorff added A8-mergeoncegreen Pull request is reviewed well. A9-buythat(wo)manabeer Pull request is reviewed well and worth buying the author a beer. A9-FUCKYEAH! Pull request is reviewed well and can not be compensated with any amount of beer in the galaxy ;) B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes C9-critical Elevates a release containing this PR to "critical priority". D7-breakseverything This change breaks the underlying networking, sync or related and thus will cause a fork labels Mar 26, 2021
JoshOrndorff
JoshOrndorff approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after a spec_version bump

@notlesh notlesh merged commit e6f98b5 into master Mar 26, 2021
@notlesh notlesh deleted the notlesh-v0.7-dependency-updates branch March 26, 2021 19:30
@JoshOrndorff JoshOrndorff mentioned this pull request Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki left review comments

@JoshOrndorff JoshOrndorff JoshOrndorff approved these changes

@crystalin crystalin crystalin approved these changes

Assignees
No one assigned
Labels
A8-mergeoncegreen Pull request is reviewed well. A9-buythat(wo)manabeer Pull request is reviewed well and worth buying the author a beer. A9-FUCKYEAH! Pull request is reviewed well and can not be compensated with any amount of beer in the galaxy ;) B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes C9-critical Elevates a release containing this PR to "critical priority". D7-breakseverything This change breaks the underlying networking, sync or related and thus will cause a fork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notlesh @girazoki @crystalin @JoshOrndorff