Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript API for runtime 2401 #2364

Closed
wants to merge 17 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Jun 20, 2023
@timbrinded timbrinded marked this pull request as ready for review June 20, 2023 11:53
@github-actions
Copy link
Contributor Author

github-actions bot commented Jun 20, 2023

Coverage generated "Thu Jun 22 14:28:02 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2364/html/index.html

Master coverage: 70.94%
Pull coverage: 70.94%

@timbrinded
Copy link
Contributor

Blocked until this is merged: polkadot-js/api#5680

@timbrinded timbrinded closed this Jun 22, 2023
@timbrinded timbrinded reopened this Jun 22, 2023
@timbrinded timbrinded marked this pull request as draft June 22, 2023 13:51
@crystalin crystalin marked this pull request as ready for review July 13, 2023 08:18
@@ -175,7 +175,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
spec_name: create_runtime_str!("moonriver"),
impl_name: create_runtime_str!("moonriver"),
authoring_version: 3,
spec_version: 2500,
spec_version: 2403,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that normal ?

@timbrinded timbrinded closed this Aug 11, 2023
@timbrinded
Copy link
Contributor

Killing this off as the branch is super old now. Will try again on a new action

@timbrinded timbrinded deleted the typescript-api-2401 branch September 6, 2023 13:31
@timbrinded timbrinded restored the typescript-api-2401 branch September 6, 2023 13:31
@timbrinded timbrinded deleted the typescript-api-2401 branch September 6, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants