Add DefaultBaseFeePerGas to runtimes
#1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgmichel
added
A0-pleasereview
librelois
approved these changes
Jan 31, 2022
crystalin
approved these changes
Jan 31, 2022
crystalin
added
A8-mergeoncegreen
notlesh
approved these changes
Jan 31, 2022
| @@ -1659,6 +1659,7 @@ impl pallet_proxy_genesis_companion::Config for Runtime { | |||
| parameter_types! { | |||
| // Tells `pallet_base_fee` whether to calculate a new BaseFee `on_finalize` or not. | |||
| pub IsActive: bool = false; | |||
| pub DefaultBaseFeePerGas: U256 = (1 * currency::GIGAWEI * currency::SUPPLY_FACTOR).into(); | |||
There was a problem hiding this comment.
It might make sense to define this in currency since it's also used for min_gas_price(). But maybe not since this will change soon (?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?