-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dawn/non specific precompiles #978
Conversation
Note: the wallet address and private key used in here are a pure throwaway dev wallet so no worries! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went thru everything and everything works great!
Just some quick thoughts on some minor things to revise.
.snippets/code/builders/ethereum/precompiles/utility/nonspecific/signMessage.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job on this! I was expecting the Dispatch and Sha3Fips sections from the MainNet precompile page to be ported over to this one as part of the original ticket though - just want to make sure that doesn't fall thru the cracks
.snippets/code/builders/ethereum/precompiles/utility/nonspecific/signMessage.js
Outdated
Show resolved
Hide resolved
.snippets/code/builders/ethereum/precompiles/utility/nonspecific/signMessage.js
Outdated
Show resolved
Hide resolved
Updates: I did not change the size on the image mentioned. I'm going to add this comment and request a fresh review from Erin so let me know if I need to modify the image. |
.snippets/text/builders/ethereum/canonical-contracts/non-specific.md
Outdated
Show resolved
Hide resolved
typos, etc. Tables should be formatted now. If they aren't correct, we need to sync for a reminder of what else I should do to them ;-) Co-authored-by: Erin Shaben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple quick things but everything looks good!
Co-authored-by: Kevin Neilson <[email protected]>
Description
I'm not sure if this requires updates on the
moonbeam-docs-cn
repo, so please let me know.Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsmove-pages.py
script to move the pages and update the image paths on the chinese repomoonbeam-docs-cn
compress-images.py
script to compress the images.moonbeam-docs-cn
repo to use the new variablesCorresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.