Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dawn/non specific precompiles #978

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Conversation

dawnkelly09
Copy link
Contributor

Description

  • Creates new page: builders/ethereum/precompiles/utility/non-specific
  • Creates content for new page: intro, explanation, and example for usage

I'm not sure if this requires updates on the moonbeam-docs-cn repo, so please let me know.

Checklist

  • [ x ] I have added a label to this PR 🏷️
  • [x ] I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • [ x] If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@dawnkelly09 dawnkelly09 added the A0 - New Content Pull request contains new content pages label Aug 15, 2024
@dawnkelly09
Copy link
Contributor Author

Note: the wallet address and private key used in here are a pure throwaway dev wallet so no worries!

Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went thru everything and everything works great!
Just some quick thoughts on some minor things to revise.

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this! I was expecting the Dispatch and Sha3Fips sections from the MainNet precompile page to be ported over to this one as part of the original ticket though - just want to make sure that doesn't fall thru the cracks

@dawnkelly09
Copy link
Contributor Author

Updates:
-> accepted suggestions from code review (thank you both!)
-> updated snippets for contract address lists to show Dispatch as Removed for all three Moonbeam networks
-> moved SHA3FIPS256 heading and paragraph from eth-mainnet.md to this page

I did not change the size on the image mentioned. I'm going to add this comment and request a fresh review from Erin so let me know if I need to modify the image.

themacexpert
themacexpert previously approved these changes Aug 21, 2024
dawnkelly09 and others added 2 commits August 23, 2024 09:39
typos, etc. Tables should be formatted now. If they aren't correct, we need to sync for a reminder of what else I should do to them ;-)

Co-authored-by: Erin Shaben <[email protected]>
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick things but everything looks good!

builders/ethereum/precompiles/utility/eth-mainnet.md Outdated Show resolved Hide resolved
builders/ethereum/precompiles/utility/non-specific.md Outdated Show resolved Hide resolved
@themacexpert themacexpert self-requested a review October 31, 2024 09:59
@themacexpert themacexpert merged commit aa4f0c3 into master Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants