Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github links throughout docs site #703

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Jul 24, 2023

Description

This PR updates GitHub links from PureStake to the new org for each repo. Note: The XCM-SDK still lives under PureStake and so do all the Docker images.

I also added in some fixes to a few items like trailing spaces and adding a language identifies to snippets. Just some small items I was seeing across some of the pages.

CN PR: moonbeam-foundation/moonbeam-docs-cn#307

@eshaben eshaben requested review from albertov19 and themacexpert and removed request for albertov19 July 24, 2023 16:36
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Here's my feedback:

I still some PureStake tags in the following files (not sure if they all need to be updated). Seems like the docker commands are still recognized with the PureStake tag but just flagging here just in case:

  • variables.yml
  • snippets/text/full-node/macos-node.md,
  • builders/get-started/networks/moonbeam-dev.md
  • tutorials/integrations/local-subsquid.md
  • node-operators/networks/run-a-node/flags.md
  • moonbeam-docs/node-operators/networks/run-a-node/docker.md

@eshaben
Copy link
Contributor Author

eshaben commented Jul 27, 2023

Good catch! Just pushed a commit 🙂

I still some PureStake tags in the following files (not sure if they all need to be updated). Seems like the docker commands are still recognized with the PureStake tag but just flagging here just in case:

Yeah, I tried with moonbeam-foundation instead of purestake and the Docker commands didn't work 🙁

@eshaben eshaben merged commit aba3c47 into master Jul 27, 2023
1 check passed
@eshaben eshaben deleted the eshaben/update-links-purestake branch July 27, 2023 04:56
@albertov19
Copy link
Contributor

Interesting, can we look more into this and if there is no alternative escalate to Tim and team?

@eshaben
Copy link
Contributor Author

eshaben commented Jul 27, 2023

I figured they were aware haha but I can talk to him yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants