-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update preimage-related docs #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left some feedback :)
Co-authored-by: albertov19 <[email protected]>
Co-authored-by: albertov19 <[email protected]>
Applied all of the feedback and switched around the images so that Xinxin only has to worry about removing images that are no longer needed once translations are done Had a question about one of the democracy precompile methods, so asked J0 and waiting on an answer before I'll request a review again |
Ok this is good to be reviewed again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Ship it 🚢
Description
This PR updates the preimage-related docs for the RT2000 breaking changes. Reference: Moonbeam PR description and Substrate PR description
👉 Democracy Pallet Changes:
👉A new Preimage Pallet page has been added.
👉 Democracy Precompile Changes:
👉 How to Submit a Proposal Changes:
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsmove-pages.py
script to move the pages and update the image paths on the chinese repomoonbeam-docs-cn
compress-images.py
script to compress the images.moonbeam-docs-cn
repo to use the new variablesCorresponding PRs
moonbeam-foundation/moonbeam-docs-cn#211
After Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Remove all of the governance proposals images under the following directory:
images/tokens/governance/proposals/for-cn/