Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Numeric names on activities/resources broke timeline #37

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

Syxton
Copy link
Contributor

@Syxton Syxton commented Sep 8, 2020

No description provided.

@timhunt timhunt merged commit c9d7bc7 into moodleou:master Dec 18, 2020
@timhunt
Copy link
Member

timhunt commented Dec 18, 2020

Thanks for fixing this.

The first half of your fix was wrong. It as already inside an if ($key == "restrict"), so $key !== "name" will always be ture.

Also, a colleage of mine had found and fixed an issue on that line, which conflicted, but I sorted that out.

@timhunt
Copy link
Member

timhunt commented Dec 18, 2020

Also, be warned, I am about to rename the default branch from master to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants