Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis cleanup, versions bump and repo name changes #4

Merged
merged 7 commits into from
Jul 10, 2020
Merged

Travis cleanup, versions bump and repo name changes #4

merged 7 commits into from
Jul 10, 2020

Conversation

kabalin
Copy link
Member

@kabalin kabalin commented Jun 30, 2020 •
edited
Loading

  • npm bump
  • Moodle 3.9
  • More Psalm exclusons (due to possible null values documented in Symfony classes)
  • blackboard-open-source > moodlehq repo name change

@kabalin
Copy link
Member Author

kabalin commented Jun 30, 2020 •
edited
Loading

Build output 🟢 https://travis-ci.org/github/kabalin/moodle-plugin-ci/builds/703594955

@kabalin kabalin force-pushed the travis-cleanup-bump branch from 592b32b to 762879c Compare June 30, 2020 16:52
@kabalin
Copy link
Member Author

kabalin commented Jun 30, 2020

Latest one 🟢 https://travis-ci.org/github/kabalin/moodle-plugin-ci/builds/703606873

andrewnicols
andrewnicols previously requested changes Jul 3, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@kabalin kabalin force-pushed the travis-cleanup-bump branch from 762879c to a632637 Compare July 3, 2020 09:27
@kabalin
Copy link
Member Author

kabalin commented Jul 3, 2020 •
edited
Loading

Latest build 🟢 https://travis-ci.org/github/kabalin/moodle-plugin-ci/builds/704599078

@andrewnicols I think I addressed all your comments, let me know if anything else is needed. Thanks for review!

@kabalin kabalin force-pushed the travis-cleanup-bump branch from feefc13 to 88afc00 Compare July 9, 2020 13:42
@kabalin
Copy link
Member Author

kabalin commented Jul 9, 2020 •
edited
Loading

Build following latest commit 🟢 https://travis-ci.org/github/kabalin/moodle-plugin-ci/builds/706533771

@kabalin kabalin changed the title Travis cleanup and versions bump Travis cleanup, versions bump and repo name changes Jul 9, 2020
@kabalin
Copy link
Member Author

kabalin commented Jul 9, 2020 •
edited
Loading

Added tiny commit to make travis file compliant with dpl v2 (notice those warnings at list build https://travis-ci.org/github/moodlehq/moodle-plugin-ci/jobs/706615874/config).

Among changes is replacing of api_key key for release phase with token (https://docs.travis-ci.com/user/deployment-v2/providers/releases/) and deprecation of skip_cleanup (now it is cleanup: false)

@stronk7
Copy link
Member

stronk7 commented Jul 9, 2020

Added tiny commit to make travis file compliant with dpl v2 (notice those warnings at list build https://travis-ci.org/github/moodlehq/moodle-plugin-ci/jobs/706615874/config).

Slightly related with this... we'll need to check .travis.dist.yml conformance too. I remember I recently performed some minor changes to some plugins (that were using moodle-plugin-ci) to achieve that. I've commented about that @ #9 .

@stronk7 stronk7 dismissed andrewnicols’s stale review July 10, 2020 15:47

It's the first time I do this, so hope it's ok (dismiss a change request). I already closed the conversation, hope this is ok.

@stronk7 stronk7 merged commit 67d9590 into main Jul 10, 2020
@stronk7 stronk7 deleted the travis-cleanup-bump branch July 10, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stronk7 stronk7 stronk7 approved these changes

@andrewnicols andrewnicols andrewnicols left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kabalin @stronk7 @andrewnicols