Remove phpcpd (deprecated) from dist and explain docs #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better stop having the deprecated phpcpd command available in the dist and explain docs, so newcomers won't enable it by default. It's going to be removed in v5. Part of moodlehq#262, credit goes to @jrchamp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
=========================================
Coverage 88.04% 88.04%
Complexity 731 731
=========================================
Files 75 75
Lines 2234 2234
=========================================
Hits 1967 1967
Misses 267 267 ☔ View full report in Codecov by Sentry. |
kabalin
approved these changes
Mar 16, 2024
|
LGTM |
|
Wow, that was quick! Thanks @kabalin ! |
|
Also merging it quickly! Heh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better stop having the deprecated phpcpd command available in the dist and explain docs, so newcomers won't enable it by default. It's going to be removed in v5.
Part of #262, credit goes to @jrchamp