Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit stylelint tasks to plugin directory #278

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

PhMemmel
Copy link
Contributor

@PhMemmel PhMemmel commented Mar 7, 2024

Closes #256

@PhMemmel PhMemmel force-pushed the Limit_stylelint_to_plugin_directory branch from bccb6de to c846e6d Compare March 11, 2024 05:54
@stronk7
Copy link
Member

stronk7 commented Mar 15, 2024

Hi @PhMemmel ,

I've put this a little bit on hold until we discuss @ #256 . Thanks for your patience!

@stronk7 stronk7 added the question Further information is requested label Mar 15, 2024
@stronk7 stronk7 force-pushed the Limit_stylelint_to_plugin_directory branch from c846e6d to 6b5a114 Compare June 12, 2024 17:34
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (cdb52da) to head (6b5a114).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #278   +/-   ##
=========================================
  Coverage     88.23%   88.23%           
  Complexity      735      735           
=========================================
  Files            76       76           
  Lines          2269     2270    +1     
=========================================
+ Hits           2002     2003    +1     
  Misses          267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7
Copy link
Member

stronk7 commented Jun 12, 2024

Hi @PhMemmel ,

I've taken the liberty of amending your commit, fixing some styling details, one test that was failing and adding the information to the changelog file.

Hope that's ok for you. If you're happy, I'll be merging this once we get all checks passing.

Ciao :-)

@PhMemmel
Copy link
Contributor Author

Feel free to add whatever is necessary! Thank you very much for taking over!

@stronk7 stronk7 merged commit 07d0f27 into moodlehq:main Jun 12, 2024
25 checks passed
@stronk7
Copy link
Member

stronk7 commented Jun 12, 2024

Merged, let's see if we can roll this soon... thanks @PhMemmel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for limiting scope of grunt
2 participants