Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci examples: use !cancelled() instead of always() #251

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

jrchamp
Copy link
Contributor

@jrchamp jrchamp commented Oct 11, 2023

As described in #248, GitHub discourages the use of always() when it can be avoided.
Fixes #248

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #251 (8407184) into master (288c8da) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #251   +/-   ##
=========================================
  Coverage     84.63%   84.63%           
  Complexity      694      694           
=========================================
  Files            74       74           
  Lines          2148     2148           
=========================================
  Hits           1818     1818           
  Misses          330      330           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stronk7
Copy link
Member

stronk7 commented Oct 16, 2023

Hi @jrchamp ,

many thanks for the patch! For me it looks perfectly ok to start suggesting to use !cancelled().

Only suggestion I have is... maybe you can add a note about the change @ docs/CHANGELOG.md, under a new Unreleased -> Changed section, with an ACTION SUGGESTED: xxxx item explaining it ?

Ciao :-)

@jrchamp
Copy link
Contributor Author

jrchamp commented Oct 20, 2023

Thanks @stronk7! I've added an item to the docs/CHANGELOG.md file.

@stronk7
Copy link
Member

stronk7 commented Oct 21, 2023

Perfect, @jrchamp, here we go!

@stronk7 stronk7 merged commit 10674c0 into moodlehq:master Oct 21, 2023
19 checks passed
@jrchamp jrchamp deleted the gha_use_cancelled branch November 17, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action: Avoid "if: always()"
2 participants