Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding some build/moodle-plugin-ci.phar basic tests #71

Closed
stronk7 opened this issue Jan 26, 2021 · 0 comments
Closed

Consider adding some build/moodle-plugin-ci.phar basic tests #71

stronk7 opened this issue Jan 26, 2021 · 0 comments
Labels
task Some task to complete

Comments

@stronk7
Copy link
Member

stronk7 commented Jan 26, 2021

All tests are performed with bin/moodle-plugin-ci and that's ok and cover 99% of uses.

But it's also possible to download moodle-plugin-ci.phar and use it on any moodle directory.

99.99% of times it will work the same than the binary... but there are cases where it may not. For example, in #68 I faced a problem about a configuration file (internal to the phar) not being loaded and leading to any codechecker execution using that phar to fail. Hopefully its fixed (workaround found).

But the point is that the problem was detected only by coincidence, because I was building the phar and decided to give it a try, there isn't anything (in make or CI checks) verifying anything using the phar.

We need to cover it, no matter they are trivial runs, but verify all them work.

That or, alternatively, we stop building the phar (although personally I find it useful, just put in in place and can run everything against any plugin (core or contrib).

Registered, to consider it. Ciao :-)

@stronk7 stronk7 added the task Some task to complete label Jan 26, 2021
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Sep 15, 2023
It's enough to run the tests once per supported PHP version.

Also, update the CHANGELOG to share about these new tests.

Closes moodlehq#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Some task to complete
Projects
None yet
Development

No branches or pull requests

1 participant