Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run nvm install as part of install command. #7

Closed
kabalin opened this issue Jul 1, 2020 · 1 comment · Fixed by #14
Closed

Run nvm install as part of install command. #7

kabalin opened this issue Jul 1, 2020 · 1 comment · Fixed by #14
Labels
enhancement New feature or request

Comments

@kabalin
Copy link
Member

kabalin commented Jul 1, 2020

We have .nvmrc these days, so picking the right version of npm should be the part of install command (rather than extra lines in install routine in travis file).

@kabalin kabalin changed the title Runnvm install as part of install command. Run nvm install as part of install command. Jul 1, 2020
@kabalin kabalin added the enhancement New feature or request label Jul 1, 2020
@stronk7
Copy link
Member

stronk7 commented Jul 1, 2020

Yeah, I faced a related problem recently when trying to bring multi-version support to moodlehq/moodle-local_codechecker#72 (comment) . There is a sort of mutual-dependency (codebase still not available) that we should kill by putting the nvm installation within the tool, not travis, or rearrange things in a way it all is in place on time.

kabalin referenced this issue in kabalin/moodle-plugin-ci Jul 17, 2020
kabalin referenced this issue in kabalin/moodle-plugin-ci Jul 17, 2020
kabalin referenced this issue in kabalin/moodle-plugin-ci Jul 17, 2020
Since Moodle 3.5 there is .nvmrc file at the top directory specifying
Node.js (npm) version Node Package Manager (nvm) should install.

We can use this to initialise Node.js environment as part of install
process, so that user would not need to worry about having correct
version of Node in before_install step.

This closes #7
kabalin referenced this issue in kabalin/moodle-plugin-ci Jul 19, 2020
Since Moodle 3.5 there is .nvmrc file at the top directory specifying
Node.js (npm) version Node Package Manager (nvm) should install.

We can use this to initialise Node.js environment as part of install
process, so that user would not need to worry about having correct
version of Node in before_install step.

This closes #7
kabalin referenced this issue in kabalin/moodle-plugin-ci Jul 19, 2020
Since Moodle 3.5 there is .nvmrc file at the top directory specifying
Node.js (npm) version Node Package Manager (nvm) should install.

We can use this to initialise Node.js environment as part of install
process, so that user would not need to worry about having correct
version of Node in before_install step.

This closes #7
kabalin referenced this issue in kabalin/moodle-plugin-ci Jul 20, 2020
Since Moodle 3.5 there is .nvmrc file at the top directory specifying
Node.js (npm) version Node Package Manager (nvm) should install.

We can use this to initialise Node.js environment as part of install
process, so that user would not need to worry about having correct
version of Node in before_install step.

This closes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants