Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-plugin action should not assume the default branch of a plugin is called 'master' #58

Closed
timhunt opened this issue Dec 16, 2020 · 1 comment
Closed

add-plugin action should not assume the default branch of a plugin is called 'master' #58

timhunt opened this issue Dec 16, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@timhunt
Copy link
Contributor

timhunt commented Dec 16, 2020

https://github.com/moodlehq/moodle-plugin-ci/blob/master/src/Command/AddPluginCommand.php

If --branch option is not given on the command-line (e.g. moodle-plugin-ci add-plugin --branch main moodleou/moodle-filter_embedquestion) then this plugin passes the branch name 'master' in the git clone command it runs. In this case, it would be better if it could just not add that argument, so that the install would use the default branch, whatever it is called (e.g. main).
@kabalin kabalin added bug Something isn't working good first issue Good for newcomers labels Dec 16, 2020
kabalin added a commit to kabalin/moodle-plugin-ci that referenced this issue Feb 3, 2021
@kabalin
AddPluginCommand should not use master branch by default.
ee99883 
As default branch could be anything, don't explicity set master if
--branch param is omitted.

Also improves tests.

Fixes moodlehq#58
@kabalin kabalin mentioned this issue Feb 3, 2021
Merged
@stronk7 stronk7 closed this as completed in 74cbee7 Feb 3, 2021
@kabalin
Copy link
Member

kabalin commented Feb 4, 2021

Thanks @timhunt, this has been addressed in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timhunt @kabalin