Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Symfony 4.4 (current LTS) #21

Closed
kabalin opened this issue Jul 20, 2020 · 3 comments
Closed

Use Symfony 4.4 (current LTS) #21

kabalin opened this issue Jul 20, 2020 · 3 comments
Labels
task Some task to complete

Comments

@kabalin
Copy link
Member

kabalin commented Jul 20, 2020

As Symfony 3.4 support comes to end in 11/2020, we need to switch Symfony packages to current LTS version: https://symfony.com/releases/4.4
@kabalin kabalin added the task Some task to complete label Jul 20, 2020
@stronk7
Copy link
Member

stronk7 commented Sep 11, 2020

Pity about this is the Sympathy 4.4 requires php71. So:

  • people will need to move their tests (matrix, jobs) up if they are still using php70.
  • minimum compatible version of Moodle will be 3.2 (older don't support php71).

stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Sep 11, 2020
@stronk7
Bump to symfony 4.4 and related dependencies
7fb5b56 
Just bump all the symfony requirements to 4.4, also bumping
other dependencies.

Importantly, this requires PHP 7.1.3 or later (versus current
PHP 7.0). Implications are:

1) People will need to stop testing things with 7.0
2) Minimum Moodle version supported will be 3.2 (versus current 3.0)

This will fix moodlehq#21 if agreed to be route.
@stronk7
Copy link
Member

stronk7 commented Sep 11, 2020

Results with just versions and dependencies updated: https://travis-ci.org/github/stronk7/moodle-plugin-ci/builds/726331973

stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Sep 15, 2020
@stronk7
Bump symfony dep injection component to ^3.4
1174ba0 
That makes a number of components to be also updated to 3.4.x
and requires php >7.0.8 (instead of 7.0.0).

A step before moodlehq#21
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Sep 15, 2020
@stronk7
Bump to symfony 4.4 and related dependencies
c5a38a0 
Just bump all the symfony requirements to 4.4, also bumping
other dependencies.

Importantly, this requires PHP 7.1.3 or later (versus current
PHP 7.0). Implications are:

1) People will need to stop testing things with 7.0
2) Minimum Moodle version supported will be 3.2 (versus current 3.0)

This will fix moodlehq#21 if agreed to be the route.
@stronk7 stronk7 mentioned this issue Sep 15, 2020
Merged
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Sep 15, 2020
@stronk7
Bump symfony dep injection component to ^3.4
4c62b34 
That makes a number of components to be also updated to 3.4.x
and requires php >7.0.8 (instead of 7.0.0).

This also changes the default node-version to '' (empty string)
because now defaults are handled different. Being strict, that
option surely should be optional, not required.

A step before moodlehq#21
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Sep 15, 2020
@stronk7
Bump symfony dep injection component to ^3.4
b4a937d 
That makes a number of components to be also updated to 3.4.x
and requires php >7.0.8 (instead of 7.0.0).

This also changes the default node-version to '' (empty string)
because now defaults are handled different. Being strict, that
option surely should be optional, not required.

A step before moodlehq#21
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Sep 15, 2020
@stronk7
Bump symfony dep injection component to ^3.4
bd9d1d8 
That makes a number of components to be also updated to 3.4.x
and requires php >7.0.8 (instead of 7.0.0).

Also updated psalm-baseline.xml to ignore 'node-version' potential
wrong assignment values.

Note I've not run --update-baseline because it comes with other
changes that I don't want to modify now (removing some options).
I leave that for the experts because I'm not sure how the baseline
is decided and which part is automatic or manual.

A step before moodlehq#21
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Sep 15, 2020
@stronk7
Bump to symfony 4.4 and related dependencies
796a1e7 
Just bump all the symfony requirements to 4.4, also bumping
other dependencies.

Importantly, this requires PHP 7.1.3 or later (versus current
PHP 7.0). Implications are:

1) People will need to stop testing things with 7.0
2) Minimum Moodle version supported will be 3.2 (versus current 3.0)

This will fix moodlehq#21 if agreed to be the route.
stronk7 added a commit to stronk7/moodle-plugin-ci that referenced this issue Sep 16, 2020
@stronk7
Bump symfony dep injection component to ^3.4
3265013 
That makes a number of components to be also updated to 3.4.x
and requires php >7.0.8 (instead of 7.0.0).

Also updated psalm-baseline.xml to ignore 'node-version' potential
wrong assignment values.

Note I've not run --update-baseline because it comes with other
changes that I don't want to modify now (removing some options).
I leave that for the experts because I'm not sure how the baseline
is decided and which part is automatic or manual.

A step before moodlehq#21
kabalin added a commit to kabalin/moodle-plugin-ci that referenced this issue Feb 3, 2021
@kabalin
Make php 7.0 happy with Execute constructor.
c132719 
This can be reverted when moodlehq#21 is addressed.
kabalin added a commit to kabalin/moodle-plugin-ci that referenced this issue Feb 3, 2021
@kabalin
Make php 7.0 happy with Execute constructor.
4a319df 
This can be reverted when moodlehq#21 is addressed.
kabalin added a commit to kabalin/moodle-plugin-ci that referenced this issue Feb 3, 2021
@kabalin
Make php 7.0 happy with Execute constructor.
2e429fe 
This can be reverted when moodlehq#21 is addressed.
@stronk7
Copy link
Member

stronk7 commented Mar 8, 2023

Closing this is favor of #151 , that is using Symfony 5, already in master branch and near 4.0.0 release.

@stronk7 stronk7 closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Some task to complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stronk7 @kabalin